Aneesh Kumar K. V wrote: > On Thu, 14 Jan 2010 11:00:39 -0600, Eric Sandeen <sandeen@xxxxxxxxxx> wrote: >> Aneesh Kumar K.V wrote: >>> This become important when we are running with nojournal mode. We >>> may end up allocating recently freed metablocks for fallocate. We >>> want to make sure we unmap the old mapping so that when we convert >>> the fallocated uninitialized extent to initialized extent we don't >>> have the old mapping around. Leaving the old mapping can cause >>> file system corruption >>> >>> Now that we unmap old metadata blocks we need not return blocks >>> allocated from fallocate area as new. >> With this, unmap_underlying_metadata_blocks is no longer used >> and can be removed I guess. >> > > Yes. Updated patch below Ok, with the latest versions of these 3 patches, fsstress / 013 is working here, modulo the blocks-past-eof-from-fallocate problem that remains. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html