On Sun, Dec 20, 2009 at 06:07:10PM +0100, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > b_entry_name and buffer are initially NULL, are initialized within a loop > to the result of calling kmalloc, and are freed at the bottom of this loop. > The loop contains gotos to cleanup, which also frees b_entry_name and > buffer. Some of these gotos are before the reinitializations of > b_entry_name and buffer. To maintain the invariant that b_entry_name and > buffer are NULL at the top of the loop, and thus acceptable arguments to > kfree, these variables are now set to NULL after the kfrees. > > This seems to be the simplest solution. A more complicated solution > would be to introduce more labels in the error handling code at the end of > the function. Thanks, added to the ext4 patch queue. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
