On Fri, 2009-12-11 at 14:02 -0600, Eric Sandeen wrote: > My first thought was that this was a bandaid too, but I guess it can > come about due to on-disk corruption for any reason, so it should > be handled gracefully, and I suppose this approach seems fine. That's why we've been running with it, yes. > Since this is catching on-disk corruption, though, it'd be better to call > ext4_error() and let the mount-time error-handling policy decide what to do. > > I like having more info but below seems awfully wordy ;) Maybe the first > printk would suffice, and switching it to an ext4_error() would be best, > I think. Okay, I'll rework the patch a bit and resubmit it. -- Frank Mayhar <fmayhar@xxxxxxxxxx> Google, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
