Re: [PATCH] ext4: Fix potential quota deadlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> We have to delay vfs_dq_claim_space() until allocation context destruction.
> Currently we have following call-trace:
> ext4_mb_new_blocks()
>   /* task is already holding ac->alloc_semp */
>  ->ext4_mb_mark_diskspace_used
>     ->vfs_dq_claim_space()  /*  acquire dqptr_sem here. Possible deadlock */
>  ->ext4_mb_release_context() /* drop ac->alloc_semp here */
> 
> Let's move quota claiming to ext4_da_update_reserve_space()
> This movement already discussed and approved during discussion
> write() vs chown() race condition.
  The patch looks good to me.

Acked-by: Jan Kara <jack@xxxxxxx>

									Honza

-- 
Jan Kara <jack@xxxxxxx>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux