On Thu, Dec 03, 2009 at 08:10:22PM -0500, tytso@xxxxxxx wrote: > On Tue, Dec 01, 2009 at 10:17:02AM -0800, Curt Wohlgemuth wrote: > > This fixes a leak of blocks in an inode prealloc list if device failures > > cause ext4_mb_mark_diskspace_used() to fail. > > I was going to say that it didn't make sense for > ext4_discard_inode_pa() should be its own function, but maybe we need > function that returns blocks back to the either inode *or* the group > preallocation list? Otherwise right now it looks like we would also > be potentially leaking blocks from the group preallocation list in > case of a device failure? For group preallocation we update the group prealloc values in ext4_mb_release_context and we use ac->ac_b_ex.fe_len to find out the count of blocks allocated. So i guess we are not going to leak blocks from group prealloc space. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
