In message <1256152779-10054-15-git-send-email-vaurora@xxxxxxxxxx>, Valerie Aurora writes: > From: Jan Blunck <jblunck@xxxxxxx> > > The ext2_append_link() is later used to find or append a directory > entry to whiteout. > > Signed-off-by: Jan Blunck <jblunck@xxxxxxx> > Signed-off-by: Valerie Aurora <vaurora@xxxxxxxxxx> > Cc: Theodore Tso <tytso@xxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx > --- > fs/ext2/dir.c | 70 ++++++++++++++++++++++++++++++++++++++++---------------- > 1 files changed, 50 insertions(+), 20 deletions(-) > > diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c > index 6cde970..cb8ceff 100644 > --- a/fs/ext2/dir.c > +++ b/fs/ext2/dir.c > @@ -472,9 +472,10 @@ void ext2_set_link(struct inode *dir, struct ext2_dir_entry_2 *de, > } > > /* > - * Parent is locked. > + * Find or append a given dentry to the parent directory > */ > -int ext2_add_link (struct dentry *dentry, struct inode *inode) > +static ext2_dirent * ext2_append_entry(struct dentry * dentry, > + struct page ** page) I thought checkpatch didn't want to see spaces after a '*', so "struct foo * ptr" should become "struct foo *ptr". I also think that "struct page **page" should be renamed to "struct page **ppage" or "struct page **pages", to avoid confusion with many other functions which pass a "struct page *" pointer to a variable named "page". Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
