On Fri, 20 Nov 2009 05:36:22 -0500 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Nov 19, 2009 at 04:34:19PM +0100, Jan Kara wrote: > > BTW: Christoph, why did you choose to call ext2_sync_fs with wait == 1 > > from ext2_write_super()? I'd think (and looking into callsites seem to > > confirm that) that ->write_super() was meant to be asynchronous... > > No particular reason - the argument wasn't and still isn't used in ext2. > And yes, now that ->sync_fs is mandatory ->write_super should be > asynchronous. > Shouldn't super block (and all other) updates be synchronous if ext2 is mounted with SYNC and DIRSYNC? -- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html