On Thu 19-11-09 10:13:17, Stephen Hemminger wrote:
> On Thu, 19 Nov 2009 16:19:53 +0100
> Jan Kara <jack@xxxxxxx> wrote:
>
> > > + if (buffer_write_io_error(sbh)) {
> > > + /*
> > > + * This happens if USB or floppy device is yanked out.
> > > + * Maybe user put device back in so warn and update again.
> > > + */
> > > + printk(KERN_ERR
> > > + "EXT2-fs: previous I/O error to superblock detected\n");
> > > + clear_buffer_write_io_error(sbh);
> > > + set_buffer_uptodate(sbh);
> > It's not much about puting the device back. It's really just about
> > avoiding the warning in mark_buffer_dirty(). So I'd just silently
> > set_buffer_uptodate and be done with it. For superblock we are darn sure
> > that in memory copy is the one that has the latest data :)
>
> This code mirrors ext4_commit_super, why should ext2 be any different?
OK, my remark was mostly about the comment which is different in ext4 ;).
I'll just fixup the comment and merge the patch. Thanks.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
