> Now that we are checking for failed journal checksums in the jbd2
> layer, we don't need to check in the ext4 mount path --- since a
> checksum fail will result in ext4_load_journal() returning an error,
> causing the file system to refuse to be mounted until e2fsck can deal
> with the problem.
>
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> ---
> fs/ext4/super.c | 20 --------------------
> 1 files changed, 0 insertions(+), 20 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8662b2e..04c6690 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2721,26 +2721,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> EXT4_HAS_COMPAT_FEATURE(sb, EXT4_FEATURE_COMPAT_HAS_JOURNAL)) {
> if (ext4_load_journal(sb, es, journal_devnum))
> goto failed_mount3;
But shouldn't we set the EXT4_ERROR_FS flag? We don't semm to do this
in ext4_load_journal() when jbd2_journal_load() fails.
Honza
--
Jan Kara <jack@xxxxxxx>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
