http://bugzilla.kernel.org/show_bug.cgi?id=14354 --- Comment #182 from Theodore Tso <tytso@xxxxxxx> 2009-11-08 19:12:34 --- On Fri, Nov 06, 2009 at 10:07:15PM +0000, bugzilla-daemon@xxxxxxxxxxxxxxxxxxx wrote: > For ext4, one thing I would suggest is to simply always put the NUL at the > end of the name, even if the filesystem might not need it. Then > nd_terminate_link() will still write the NUL, but it won't change any data > (and thus no CRC's). It's pretty simple to do this; in fact it's a one-line change in ext4_symlink() in fs/ext4/inode.c: /* clear the extent format for fast symlink */ EXT4_I(inode)->i_flags &= ~EXT4_EXTENTS_FL; inode->i_op = &ext4_fast_symlink_inode_operations; - memcpy((char *)&EXT4_I(inode)->i_data, symname, l); + strcpy((char *)&EXT4_I(inode)->i_data, symname); inode->i_size = l-1; - Ted -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
