On 2009-11-04, at 13:40, Alexey Fisher wrote:
i trying to make messages produced by ext2 more unified. It should be
easy to parse.
This patch follows the ext4_msg() changes in ext4, so at least it is
not inventing something different.
Reviewed-by: Andreas Dilger <adilger@xxxxxxx>
Minor note:
@@ -840,8 +858,9 @@ static int ext2_fill_super(struct super_block
*sb, void *data, int silent)
(EXT2_HAS_COMPAT_FEATURE(sb, ~0U) ||
EXT2_HAS_RO_COMPAT_FEATURE(sb, ~0U) ||
EXT2_HAS_INCOMPAT_FEATURE(sb, ~0U)))
- printk("EXT2-fs warning: feature flags set on rev 0 fs, "
- "running e2fsck is recommended\n");
+ ext2_msg(sb, KERN_WARNING,
+ "warning: feature flags set on rev 0 fs, "
+ "running e2fsck is recommended");
It looks like you have an extra space before the ext2_msg() here.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
