On Thu, Oct 08, 2009 at 06:13:33PM -0700, Mingming wrote:
> ext4: code clean up for dio fallocate handling
>
> The ext4_debug() call in ext4_end_io_dio() (inode.c) has a
> should be moved after checking the io_end structure to be not a NULL pointer.
>
> The comment above ext4_get_block_dio_write() ("Maximum
> number of blocks...") is a duplicate; the original and correct comment
> is above the #define DIO_MAX_BLOCKS up above.
>
> The check for allocated > max_blocks in ext4_split_unwritten_extents()
> can be removed, since the code returns immediately once allocated blocks is
> less or equals to the requested blocks to convert.
>
> Based on review comments from Curt Wohlgemuth.
>
> Signed-off-by: Mingming Cao <cmm@xxxxxxxxxx>
The changes described last paragraph wasn't in the patch. I assume it
was because patch #4 in this series changed:
if (allocated <= max_blocks)
to:
if (iblock == ee_block && allocated <= max_blocks)
I replaced the commit description with the following:
ext4: code clean up for dio fallocate handling
From: Mingming <cmm@xxxxxxxxxx>
The ext4_debug() call in ext4_end_io_dio() should be moved after the
check to make sure that io_end is non-NULL.
The comment above ext4_get_block_dio_write() ("Maximum number of
blocks...") is a duplicate; the original and correct comment is above
the #define DIO_MAX_BLOCKS up above.
Based on review comments from Curt Wohlgemuth.
Signed-off-by: Mingming Cao <cmm@xxxxxxxxxx>
Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
Added to the patch queue
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
