Julia Lawall wrote:
The function ext4_da_writepages_trans_blocks contains the following code:
if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
(max_blocks > EXT4_MAX_TRANS_DATA))
max_blocks = EXT4_MAX_TRANS_DATA;
Elsewhere the constant EXT4_EXTENTS_FL is used as follows:
EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL
Should that be done in ext4_da_writepages_trans_blocks as well?
thanks,
julia
Ouch, yes, looks like a bug. I don't think that value would ever be set
on the vfs inode's i_flags so we're always going down that path.
It's probably not catastrophic; if I'm reading it right we are just
being more conservative all the time.
Want to send a patch? :)
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
