2009/10/10 2:20, Andreas Dilger wrote:: > > On 8-Oct-09, at 02:04, Kazuya Mio wrote: > >> EXT4_IOC_MOVE_EXT changes donor file data, but doesn't update >> ctime/mtime. >> This patch fixes this problem. > > I would argue that just migrating the file data shouldn't update the > ctime/mtime. > Those are used to determine if the file has changed in some way, usually > for the > purpose of backup. Migrating the data does not change anything from the > user-space > POV and shouldn't force a new backup of the file. EXT4_IOC_MOVE_EXT always changes the original actual contents of donor file if orig file and donor file aren't the same. It may be that some of user-space implementations hide such a changing. For example, e4defrag unlinks the donor file, and removes it by decreasing reference count after calling EXT4_IOC_MOVE_EXT. But from the ioctl point of view, EXT4_IOC_MOVE_EXT doesn't know whether donor file will be removed or not, so I think we should update ctime/mtime. Am I missing something? Regards, Kazuya Mio -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
