Re: [PATCH 2/2] pu branch: make fs->group_desc opaque

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 24, 2009 at 09:35:47PM -0500, Eric Sandeen wrote:
> To prevent direct array indexing of fs->group_desc[i] (because
> the group_desc may be a different size for different filesystems)
> make it an opaque pointer that may only be accessed through the
> accessor functions in blknum.c.  The type itself is still available
> in a public header; if we have a group_desc that we know is one type
> or another, it's ok to access its fields directly.  This change only
> prevents us from indexing off fs->group_desc[i] directly.
>
> Change the accessors in blknum.c to use ext4fs_group_desc(), a version
> of ext2fs_group_desc() which returns a ext3_group_desc pointer.
>
> This simplifies and collapses a fair bit of code in blknum.c
>
> Tested with "make check" but no 64-bit testing yet.
>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks, I've added it to the pu branch in my sources.

	     	      	     		      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux