On Sep 23, 2009 22:27 -0700, Jiaying Zhang wrote: > Sorry for taking so long to finish this. Here is the new patch based on > Andreas's suggestions. Now the patch clears the EXT4_EOFBLOCKS_FL > flag when we allocate beyond the maximum allocated block. I also > made the EOFBLOCKS flag user visible and added the handling > in ext4_ioctl as Andrea suggested. > > Index: linux-2.6.30.5/include/linux/fs.h > =================================================================== > +#define FS_EOFBLOCKS_FL 0x00200000 /* Blocks allocated beyond EOF */ Can you please use 0x00400000 here. I've already asked Ted to reserve the 0x0020000 inode flag for use by large extended attributes. > #define FS_RESERVED_FL 0x80000000 /* reserved for ext2 lib */ > > -#define FS_FL_USER_VISIBLE 0x0003DFFF /* User visible flags */ > +#define FS_FL_USER_VISIBLE 0x0023DFFF /* User visible flags */ This would need to be changed to 0x0043DFFF to match. Sorry, I haven't looked at the rest of the patch yet, just thought I'd mention this early on. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
