Hi Eric, Thanks for your comment. On Tue, 15 Sep 2009 10:15:58 -0500 Eric Sandeen <sandeen@xxxxxxxxxx> wrote: > Toshiyuki Okajima wrote: > > Hi Ted, Andrew and all. > > > > Under the current implementation, we cannot know in the system log > > (/var/log/messages) when the filesystem (ext2/ext3/ext4) is unmounted. > > For enterprise users, they often want to observe certain filesystems' > > actions (mount/unmount) in the system log. Besides, by the system log, > > we occasionally wants to know whether a certain filesystem has been > > unmounted or not at the time when a problem happens. > > > > The following patch series implement above demand. > > Please apply it. > > If this is really a common requirement, perhaps we should at least > consider putting it in the vfs, in vfs_kern_mount(), > generic_shutdown_super(), and do_remount_sb(). Yes. I also thought it was appropriate that where this feature was implemented was on VFS. But ext3/ext4 has already included the message mechanism which operates when ext3/ext4 is mounted/remounted. So, to achieve this feature easily, I have rearranged the message mechanism in ext3/ext4 (ext2 is newly implemented). > > That way we'll have common behavior and less replicated code; nothing in > this patch series is unique to ext[234] as far as I can tell. > > sb->s_type->name could be used to print the fs type in a generic message. Thanks, Toshiyuki Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
