Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> ...  				}
> diff --git a/e2fsck/super.c b/e2fsck/super.c
> index 409d472..b8eee6b 100644
> --- a/e2fsck/super.c
> +++ b/e2fsck/super.c
> @@ -637,8 +637,8 @@ void check_super_block(e2fsck_t ctx)
>  		should_be = 0;
>  		if (!ext2fs_group_desc_csum_verify(fs, i)) {
>  			if (fix_problem(ctx, PR_0_GDT_CSUM, &pctx)) {
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_INODE_UNINIT);
>  				ext2fs_bg_itable_unused_set(fs, i, 0);
>  				should_be = 1;
>  			}

Wouldn't something like this be better? There are a few places where this
could be done:


> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT | EXT2_BG_INODE_UNINIT);


Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux