On Sep 05, 2009 18:32 -0400, Theodore Ts'o wrote: > Now that we have cleaned up journal_async_commit, it's safe to enable > it all the time. But we only want to do so if ext4-specific INCOMPAT > features are enabled, since otherwise we will prevent the filesystem > from being mounted using ext3. So, the big question is what to do if not-the-last transaction in the journal has a bad block in it? This is fairly unlikely, and IMHO the harm of aborting journal replay too early is likely far outweighed by the benefit of not "recovering" garbage directly over the filesystem metadata. I had thought that you had rejected the e2fsck side of this patch for that reason, but maybe my memory is faulty... We still have some test images for bad journal checksums that you can have if you want. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
