Nick Dokos wrote:
Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
Replace all field accesses with calls to access functions.
Most importantly, get rid of the mis-declared group descriptor
pointer which caused the wrong fields to be updated.
Not quite sure what you mean by this? It worked ok for the "old" size ...
Yes, it worked fine for the old ext2_group_desc structure, but it has no
hope of working with the ext4_group_desc: the sizes are different, so
doing bg++ gets it pointing somewhere within the first descriptor, not
to the beginning of the second. That's how it ended up modifying
reserved fields.
right. Ok, I was just confused when you said "mis-declared" - thought
you meant something was wrong with how bg was set or initialized.
Sorry about the whitespace problems. As for the flags, I didn't worry
too much about how to set them: I figured that once the dust settles,
we'll follow the proper convention.
sounds good.
Thanks,
-Eric
Thanks for looking it over and testing too! We'll see whether Justin's
problem disappears.
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
