On Wed, Sep 2, 2009 at 11:54 AM, Peng Tao<bergwolf@xxxxxxxxx> wrote: > Hi, Akira, > > Akira Fujita wrote: >> ext4: Return exchanged blocks count to user space in failure >> >> From: Akira Fujita <a-fujita@xxxxxxxxxxxxx> >> >> Return exchanged blocks count (moved_len) to user space, >> if ext4_move_extents() failed on the way. > Even with the patch, I still don't see how users can fix EXT4_IOC_MOVE_EXT failures, > because the orig file itself may be broken. Peng, I have not looked at the code very closely, but can you tell me where a file corruption can take place? Not completing the replacement of extents with donor extents is one thing. Corrupting the original file contents is another. Clearly we need EXT4_IOC_MOVE_EXT to fail gracefully and not corrupt the original file the vast majority of the time. Greg -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
