2009/9/2 Akira Fujita <a-fujita@xxxxxxxxxxxxx>: > ext4: Remove unneeded BUG_ON() in ext4_move_extents() > > From: Akira Fujita <a-fujita@xxxxxxxxxxxxx> > > ext4_move_extents() checks with BUG_ON() whether > the exchanged blocks count accords with request blocks count. > But, if the target range (orig_start + len) includes sparse block(s), > 'moved_len' (exchanged blocks count) does not accord with > 'len' (request blocks count), > since sparse block is not counted in 'moved_len'. > Therefore we hit BUG_ON(), though it succeeded. I can confirm the bug in my test cases too. > > Signed-off-by: Akira Fujita <a-fujita@xxxxxxxxxxxxx> > --- > fs/ext4/move_extent.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c > index 60ed567..643156a 100644 > --- a/fs/ext4/move_extent.c > +++ b/fs/ext4/move_extent.c > @@ -1323,8 +1323,5 @@ out2: > if (ret) > return ret; > > - /* All of the specified blocks must be exchanged in succeed */ > - BUG_ON(*moved_len != len); > - > return 0; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Cheers, Peng Tao State Key Laboratory of Networking and Switching Technology Beijing Univ. of Posts and Telecoms. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
