Re: [patch 06/11] ext2: convert to use the new truncate convention.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>   Hi,
> 
> > I also have commented a possible bug in existing ext2 code, marked with XXX.
>   Looks good, except:
> 
> > +int ext2_setsize(struct inode *inode, loff_t newsize)
>   This could be static.
> 
> > @@ -1459,8 +1540,15 @@ int ext2_setattr(struct dentry *dentry,
> >  		if (error)
> >  			return error;
> >  	}
> > -	error = inode_setattr(inode, iattr);
> > +	if (iattr->ia_valid & ATTR_SIZE) {
> > +		error = ext2_setsize(inode, iattr->ia_size);
> > +		if (error)
> > +			return error;
> > +	}
> > +	generic_setattr(inode, iattr);
>   Here, we should store the error code I suppose...
  Ah, I was confused. generic_setattr() returns void. But then remove
the check !error from:
  if (!error && (iattr->ia_valid & ATTR_MODE))
which just follows the generic_setattr(). That's what made me think
generic_setattr() returns something :)

									Honza
-- 
Jan Kara <jack@xxxxxxx>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux