On Wed 19-08-09 12:26:38, Christoph Hellwig wrote: > Looks good to me. Eventually we should use those SYNC_ flags also all > through the fsync codepath, but I'll see if I can incorporate that in my > planned fsync rewrite. Yes, I thought I'll leave that for later. BTW it should be fairly easy to teach generic_sync_file() to do fdatawait() before calling ->fsync() if the filesystem sets some flag in inode->i_mapping (or somewhere else) as is needed for XFS, btrfs, etc. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html