On Wed, Jul 29, 2009 at 06:58:16PM +0300, Alexander Shishkin wrote: > Will something like this do? > > The only blocks that might theoretically (although very unlikely) be > dangerous for newly-created filesystem's integrity are those that > still contain valid signatures, others can be safely skipped. > > Since reads are generally faster (or at least, not slower), this > gives some performance increase during mkfs run. Did you bother benchmarking what this would do on normal disk drives? Previously we were writing out the blocks to be zeroed in large chunks at a time for speed reasons. This patch reduces it to reading the journal one block at a time, and if it contains a valid signature it writes a zero block. The patch also doesn't check for commit blocks, which are just as much a problem (if not more so) than revoke blocks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
