Christoph Hellwig wrote: > On Wed, Jul 15, 2009 at 03:21:11PM -0500, Eric Sandeen wrote: ... >> (md5sums may just be reading buffered data though, >> suggestions?) > > As Andreas said unmount it before. > >> The test currently expects to find e4defrag in >> /usr/bin > >> +_supported_fs xfs ext4 > >> +fragfile=$SCRATCH_MNT/fragfile.$$ >> + >> +if [ "$FSTYP" == "xfs" ]; then >> + DEFRAG=/usr/sbin/xfs_fsr >> +else >> + DEFRAG=/usr/bin/e4defrag >> +fi >> + >> +_require_command $DEFRAG >> +_require_command /usr/sbin/filefrag > > I think we're much better off adding a helpers for this in a new > common.defrag (or adding it somwhere). > > Then set a DEFRAF_PROG variable there, and add a _require_defrag > ala Both ideas sound good, will send a V2. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
