>
> diff -Naur orig/fs/ext4/namei.c new/fs/ext4/namei.c
> --- orig/fs/ext4/namei.c 2009-07-14 11:19:46.000000000 -0700
> +++ new/fs/ext4/namei.c 2009-07-14 11:19:28.000000000 -0700
> @@ -1498,12 +1498,14 @@
>
> sb = dir->i_sb;
> blocksize = sb->s_blocksize;
> - if (!dentry->d_name.len)
> - return -EINVAL;
> + if (!dentry->d_name.len) {
> + retval = -EINVAL;
> + goto out;
> + }
>
Do we really need those goto changes. We just return even at the label "out".
Seperating that out of the patch makes review easier
-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
