On Mon 13-07-09 09:19:01, Theodore Tso wrote: > On Fri, Jul 10, 2009 at 12:07:13PM +0200, Jan Kara wrote: > > Yes, it should be "this should never happen", unless you run something > > like tune2fs while the filesystem is mounted. But looking at the code, I > > have missed that buffer could be dirty also in > > jbd2_journal_get_create_access() because jbd2_journal_forget() does not > > clear the dirty bit in case the buffer is just being committed. Attached > > patch should fix it. Thanks for report. > > Thanks, added to the patch queue. I've been doing some more tests here and there's one more path which emits the warning when deleting symlinks (falsely this time). I'll send you the fix when I verify that I cannot trigger the warning anymore. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html