On Wed, Jun 17, 2009 at 02:51:30PM +0900, Akira Fujita wrote: > Hi Ted, > > Theodore Tso wrote: > > As a side note, the static functions in fs/ext4/move_extent.c really > > don't need the ext4_mext prefix, since static functions don't have > > namespace issues that require a consistent naming scheme. (Sometimes > > a shorter name can also be useful since it avoids needing to line wrap > > function calls with a long list of parameters.) > > This patch is for "online-defrag" in the ext4 patch queue, > and changes are as follows: > > - Remove unneeded function prefix (ext4_mext_ or ext4_) > in fs/ext4/move_extent.c to make function name shorter. > And change some name of functions. > - Fix error handling issue. > - Add some argument checks. > > If this patch does not seem to have any problem, > could you add this change to the ext4 patch queue? Thanks for your patch; I've folded your improvements changes into the online-defrag patch in the ext4 patch queue. Best regards, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
