Aneesh Kumar K.V wrote: > On Mon, May 11, 2009 at 11:17:09PM -0400, Theodore Tso wrote: >> On Thu, May 07, 2009 at 04:09:30PM +0530, Aneesh Kumar K.V wrote: >>> We should not do submit_bh for delayed and unwritten extents. So >>> add a BUG_ON on them. >> Hmm, maybe we should add a BUG_ON(buffer_new(bh)) here to? That flag >> should never leak out to submit_bh as well, right? >> > > Yes . But since BH_New is used by all the filesystems we need to > verify them and make sure other filesystems gets it right. IIUC BH_Delay and > BH_Unwritten are only used by ext4, xfs and btrfs > > -aneesh I have confirmed that xfs won't care what we do in submit_bh... so BUG_ONs here related to delay/unwritten won't worry xfs. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html