On Sun, May 10, 2009 at 07:57:41PM -0400, Theodore Tso wrote: > On Thu, May 07, 2009 at 10:20:26AM -0500, Eric Sandeen wrote: > > Aneesh Kumar K.V wrote: > > > These buffer_heads are allocated on stack and are > > > used only to make get_blocks calls. So we can set the > > > b_state to 0 > > > > > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> > > > > I'd noticed this too, thanks for fixing up. > > Is this just a clean-up, or does this fix a bug? It wasn't obvious > the patch description. (I'm not a big fan of Ingo's 'Impact: ' > header, but it is good to make sure the patch description explains the > impact of a patch.) If you are taking patch 3/3 you would need this patch. But otherwise you can drop this. The fix is actually in patch 2/3. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html