Re: [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extents in submit_bh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aneesh Kumar K.V wrote:
> We should not do submit_bh for delayed and unwritten extents. So
> add a BUG_ON on them.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>

Makes sense to me, once we get our own house in order.  :)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  fs/buffer.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index b3e5be7..ec480c8 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2931,6 +2931,8 @@ int submit_bh(int rw, struct buffer_head * bh)
>  	BUG_ON(!buffer_locked(bh));
>  	BUG_ON(!buffer_mapped(bh));
>  	BUG_ON(!bh->b_end_io);
> +	BUG_ON(buffer_delay(bh));
> +	BUG_ON(buffer_unwritten(bh));
>  
>  	/*
>  	 * Mask in barrier bit for a write (could be either a WRITE or a

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux