On Sat, May 02, 2009 at 10:05:28PM -0400, Theodore Tso wrote:
> On Mon, Apr 27, 2009 at 03:00:57PM +0200, Karel Zak wrote:
> > The libblkid (since v1.41.1) returns private device-mapper names (e.g.
> > /dev/dm-0). It's because the probe_one() function scans /dev before
> > /dev/mapper.
>
> Checked in, thanks. Debian-derived distributions don't create
> /dev/dm-X names, which is why I didn't notice this issue. However,
> because of this, I modified your patch to keep this chunk which you removed:
You needn't this chunk.
> > - /* Do a short-cut scan of /dev/mapper first */
> > - if (!devname)
> > - blkid__scan_dir("/dev/mapper", devno, 0, &devname);
>
> For distributions that don't create /dev/dm-X devices, your check
I guess that all distributions have "dm-X" names in /proc/partitions, it
means my check
if (!strncmp(ptname, "dm-", 3) && isdigit(ptname[3]))
blkid__scan_dir("/dev/mapper", devno, 0, &devname);
works everywhere and you needn't to check /dev before /dev/mapper for
dm-X ptnames.
> above won't find the device name, so after searching /dev, we need to
> do a short-cut scan of /dev/mapper before we do a full brute force
> search via blkid_devno_to_devname.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
