Aneesh Kumar K.V wrote: > On Wed, Apr 29, 2009 at 11:35:21AM -0400, Theodore Tso wrote: >> On Wed, Apr 29, 2009 at 10:17:21AM +0530, Aneesh Kumar K.V wrote: >>> Block number '0' should not be used as the fake block number for >>> the delayed new buffer. This will result in vfs calling umap_underlying_metadata for >>> block number '0'. So use -1 instead. >> sector_t is an unsigned type, so we probably want to use ~0 instead of >> -1. I can fix this up before we apply into the patch queue. >> >> Are we agreed both of these should probably be pushed to Linus for >> 2.6.30? >> > > With ABAT I am seeing the below error during fsstress run. > > EXT4-fs: mounted filesystem sdb1 with ordered data mode > attempt to access beyond end of device > sdb1: rw=1, want=0, limit=136713087 > Buffer I/O error on device sdb1, logical block 18446744073709551615 Ok, I think this is actually good. Looks like we are leaking uninitialized delalloc buffer heads... this may well explain some of the corruptions we've seen. So now .... what's going on ... :) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
