On Fri, May 01, 2009 at 12:37:16AM -0400, Theodore Ts'o wrote: > The s_dirt flag wasn't completely handled correctly, but it didn't > really matter when journalling was enabled. It turns out that when > ext4 runs without a journal, we don't clear s_dirt in places where we > should have, with the result that the high-level write_super() > function was writing the superblock when it wasn't necessary. > > So we fix this by making ext4_commit_super() clear the s_dirt flag, > and removing many of the other places where s_dirt is manipulated. > When journalling is enabled, the s_dirt flag might be left set more > often, but s_dirt really doesn't matter when journalling is enabled. Btw, you might want to move all s_dirt setting into a wrapper, so that it never gets set for journal mode. That way we can avoid superflous calls into the filesystem in that default mode. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
