Robert P. J. Day wrote:
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
Looks fine, thanks.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 2958f4e..479d5ef 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1479,7 +1479,7 @@ set_qf_format:
> return 0;
> if (option < 0 || option > (1 << 30))
> return 0;
> - if (option & (option - 1)) {
> + if (!is_power_of_2(option)) {
> printk(KERN_ERR "EXT4-fs: inode_readahead_blks"
> " must be a power of 2\n");
> return 0;
> @@ -2092,7 +2092,7 @@ static ssize_t inode_readahead_blks_store(struct ext4_attr *a,
> return -EINVAL;
>
> /* inode_readahead_blks must be a power of 2 */
> - if (t & (t-1))
> + if (!is_power_of_2(t))
> return -EINVAL;
>
> sbi->s_inode_readahead_blks = t;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
