On Wed, Apr 08, 2009 at 08:00:33AM +0200, Jens Axboe wrote: > > I think you should comment on why we don't need to do the actual unplug. > See what I added in fs/jbd/commit.c:journal_commit_transaction(): > > /* > * Use plugged writes here, since we want to submit several > * before we unplug the device. We don't do explicit > * unplugging in here, instead we rely on sync_buffer() doing > * the unplug for us. > */ OK, agreed. I'll add a comment explaining what is going on in the patch; better there than in the commit log. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
