Chris Mason wrote:
On Mon, 2009-03-30 at 22:01 +0900, Fernando Luis Vázquez Cao wrote:
Chris Mason wrote:
On Sun, 2009-03-29 at 22:22 -0500, Eric Sandeen wrote:
Theodore Tso wrote:
On Sun, Mar 29, 2009 at 12:43:22PM -0500, Eric Sandeen wrote:
As long as we keep the call there this is probably good, but after
talking w/ Chris Mason, I think the call is extraneous anyway and should
probably just be removed...
Yes, I agree, but it takes a lot of digging to be completely sure of
that it's safe to remove it. Interestingly, it was you who added the
patch which added the call to blkdev_issue_flush():
commit d755fb384250d6bd7fd18a0930e71965acc8e72e
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri Jul 11 19:27:31 2008 -0400
Yes, it was. Although I got the idea when hch pointed out that SuSE did
this... thanks to Chris. It's come full circle. :)
Grin. I'm not sure the I_DIRTY checks alone are enough to decide that a
commit is required though. I think the inode could be clean but still
have metadata that needs commit.
Chris, I have just sent patches that attempt to fix both ext3 and
ext4 while also adding a per-device sysfs knob tu disable
write-flushes. A previous version of this patch set added a new
generic mount option but comments from Christoph and others
convinced me to turn it into a per-device tunable. Could you take
a look at the patches?
Jens' comment are right on I think. If we get that fixed up we can get
rid of all the filesystem mount -o barrier=flush,0,1,xyz confusion and
set it via the block devices directly.
That would be nice ;)
Thank you for your feedback, Chris! I will address some of the issues spotted
in the mailing list and resend the whole patch-set.
Regards,
Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
