On Tue, Feb 24, 2009 at 03:13:39PM -0600, Eric Sandeen wrote: > The coverity scanner found this one. > > If a line in modules.dep has a ":" but no "/" then: > > if ((cp = strchr(buf, ':')) != NULL) > *cp = 0; > else > continue; > if ((cp = strrchr(buf, '/')) != NULL) > cp++; > /* XXX else cp is still null */ > i = strlen(cp); > > ... we will deref a null pointer (cp). This can be > demonstrated by putting a line like: > > foo.ko: > > into modules.dep. The below change just says that if no "/" is > found, treat the whole string as the module name. Thanks, applied to the e2fsprogs git tree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
