On Thu 05-02-09 16:37:44, Theodore Tso wrote: > On Thu, Feb 05, 2009 at 03:52:59PM +0100, Jan Kara wrote: > > > > > the three patches below fix a bug in > > jbd2_journal_begin_ordered_truncate() that could possibly lead to > > NULL pointer dereference. The question is how to merge the fix as it > > changes the prototype of the function and both ext4 and ocfs2 use > > it. Mark, Mingming, any suggestions? > > Jan, how how easy is it to hit this? Do you believe we should try to > get this in for 2.6.29? I got some final things to push to Linus so > I can also push it via the ext4 tree. I doubt it will conflict with > > anything in my tree, either. The possibility of hitting this is quite small. We check inode->i_transaction for NULL just before dereferencing it so the commit would have to set it to NULL just between those two instructions. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
