On Tue, 3 Feb 2009 11:23:03 +0300 (EAT) Dan Carpenter <error27@xxxxxxxxx> wrote: > This is jbd2_journal_begin_ordered_truncate() from fs/jbd2/transaction.c. > > I think the "&&" is supposed to be an "||" on line 2144. Just knowing > that inode->i_transaction is NULL should be enough, otherwise we would > immediately dereference a null on line 2146. > > 2144 if (!inode->i_transaction && !inode->i_next_transaction) > 2145 goto out; > 2146 journal = inode->i_transaction->t_journal; > Could be. Hard to tell from the code, changelog and (non) comments. Perhaps it's dead code. Send a patch, become famous ;) While you're there, rename local var `inode' to `jinode'. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
