Hi Derkjan, Derkjan de Haan wrote:
I would like to report the following issues: - the patch doesn't apply cleanly to 2.6.29-rc3: Applying patch patches/1 patching file fs/ext4/Makefile patching file fs/ext4/defrag.c patching file fs/ext4/ext4.h Hunk #1 succeeded at 303 (offset 10 lines). Hunk #2 succeeded at 312 with fuzz 2 (offset -2 lines). Hunk #3 succeeded at 1033 (offset 9 lines). patching file fs/ext4/ext4_extents.h patching file fs/ext4/extents.c patching file fs/ext4/ioctl.c Hunk #2 succeeded at 215 (offset -11 lines). Applying patch patches/2 patching file fs/ext4/defrag.c Now at patch patches/2
Defrag pathces applied cleanly to the ext4 patch queue (7554f240866634a3b5394aced79e1768b4b1f3bf) without any hunks. [root@bsd086 KERN]# patch -d linux-2.6.29-rc3 -p1 < 1.patch patching file fs/ext4/Makefile patching file fs/ext4/defrag.c patching file fs/ext4/ext4.h patching file fs/ext4/ext4_extents.h patching file fs/ext4/extents.c patching file fs/ext4/ioctl.c Maybe your ext4 patch queue was not the latest version.
- I just found out e4defrag needs to be compiled with the -lm flag due to the powf function being used.
Yes. I should have mentioned it in advance.
- When compiling ext4 as a module, the kernel build fails on this error: ERROR: "fget_light" [fs/ext4/ext4.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2
Thank you for reporting. I will use fget() and fput() in the next version instead. Regards, Akira Fujita -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
