On Tue, Jan 20, 2009 at 05:05:27PM +0100, Jan Kara wrote: > we noted in our testing that ext2 (and it seems some other filesystems as > well) don't flush disk's write caches on cases like fsync() or changing > DIRSYNC directory. This is my attempt to solve the problem in a generic way > by calling a filesystem callback from VFS at appropriate place as Andrew > suggested. For ext2 what I did is enough (it just then fills in > block_flush_device() as .flush_device callback) and I think it could be > fine for other filesystems as well. The only question I have is why this would be optional. It would seem that this would be the preferred default behavior for all block filesystems. We have the backing_dev_info and a way to override the default if a filesystem needs something special. Joel -- "A narcissist is someone better looking than you are." - Gore Vidal Joel Becker Principal Software Developer Oracle E-mail: joel.becker@xxxxxxxxxx Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html