Simon Holm Thøgersen wrote: > man, 05 01 2009 kl. 12:11 -0800, skrev Randy Dunlap: >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> >> Fix jbd2 printk format: >> >> fs/jbd2/journal.c:848: warning: format '%lu' expects type 'long unsigned int', >> but argument 3 has type 'uint32_t' >> >> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> --- >> fs/jbd2/journal.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> --- linux-next-20090105.orig/fs/jbd2/journal.c >> +++ linux-next-20090105/fs/jbd2/journal.c >> @@ -845,7 +845,8 @@ static int jbd2_seq_info_show(struct seq >> seq_printf(seq, " %ums logging transaction\n", >> jiffies_to_msecs(s->stats->u.run.rs_logging / s->stats->ts_tid)); >> seq_printf(seq, " %luus average transaction commit time\n", >> - do_div(s->journal->j_average_commit_time, 1000)); >> + (unsigned long)do_div(s->journal->j_average_commit_time, >> + 1000)); >> seq_printf(seq, " %lu handles per transaction\n", >> s->stats->u.run.rs_handle_count / s->stats->ts_tid); >> seq_printf(seq, " %lu blocks per transaction\n", > > This patch is just as wrong as the original code. Please don't > apply it, but see my "[PATCH] jbd2: fix wrong use of do_div" > that I just sent out. ok, where did you send it? I don't see it... -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
