On Sat, Jan 10, 2009 at 03:40:16PM -0500, Steven Rostedt wrote: > > Actually, that's one of the things ftrace is suppose to do, and is on my > todo list. To track all trace points, and be able to hook into any one and > print them out to the trace. As a feature request, can this include actually printing the data which gets captured at a tracepoint, and not just the fact that we hit a particular tracepoint? One nice thing about the markers infrastructure was it included a printk format strong, so this would have been very easy. The current tracepoints insertion hook, while convenient in that you can just pass it a data structure like this: + trace_ext4_sync_file(file, dentry, datasync); ....instead of this... - trace_mark(ext4_sync_file, "dev %s datasync %d ino %ld parent %ld", - inode->i_sb->s_id, datasync, inode->i_ino, - dentry->d_parent->d_inode->i_ino); Has as its downside the fact that it's going to be difficult for ftrace to be able to pretty-print the contents of data structure. Where as with the trace_mark() format string, it would be trivially easy for ftrace to print the information captured at the trace point. For the bulk of the ext4 tracepoints, merely logging the fact that we hit the "ext4_sync_file" tracepoint isn't going to be particularly interesting; it's the data associated with hitting that particular tracepoint which I really want to be able to get access to. (And why I decided to use markers instead of tracepoints. With systemtap, I can access the markers *today* looks like being able to do something useful with tracepoints is still a work in progress.... But as I said, I've been warning the Systemtap folks for a while now that they don't get their act together, there will be replacements written by kernel developers that will be designed to be useful for kernel developers --- but they chose not to believe James Bottomley or myself, and blew us off --- so when there is a functional equivalent ready, I'm happy to switch; it just doesn't seem quite there yet.) - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
