On Tue, Dec 09, 2008 at 04:11:22PM +0530, Aneesh Kumar K.V wrote: > The problem is due to remove-do_blk_alloc patch. > > The patch below should fix the crash. > > - EXT4_I(inode)->i_allocated_meta_blocks += *count; > + EXT4_I(inode)->i_allocated_meta_blocks += ar.len; Good catch, thanks. I'll add it to the patch queue. > I have one question regarding the patch. What about blocks allocated for > directories for the ext3 format. With extent format we are not > setting EXT4_MB_HINT_DATA for non regular files. So i guess we also > need the below patch . One of the good things about getting rid of too many layers of abstractions is that it makes bugs like this easier to spot. We've been sending allocating directory and symlinks using EXT4_MB_HINT_DATA if extents haven't been enabled, and no one noticed before we simplified out things.... Actually, I wonder if maybe we should set EXT4_MB_HINT_DATA for directories as well. Making directories contiguous does speed up certain workloads, and it does speed up fsck. It may be though that the mballoc algorithms should be tuned specifically for directories, and what we should do is to define a new flag, EXT4_MB_HINT_DIRECTORY, and pass it in for that case. Some experimentation is clearly called for, here.... - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
