Re: [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bill Davidsen wrote:
I seriously disagree on that, writing it as a for makes it totally clear that the index initialization is part of the loop. I know, looks funny, not the way we have always done it, not invented here...

Just to be clear, I didn't mean that in any bad way, just that sometimes a new format, even if correct and unambiguous, looks strange to the eye and is not used just because it jars. I still think putting initialization for a loop in the start of the for is defensive programming, perhaps I've had too many bumblers inherit my code.

--
Bill Davidsen <davidsen@xxxxxxx>
 "Woe unto the statesman who makes war without a reason that will still
be valid when the war is over..." Otto von Bismark

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux