Hi Ted, Theodore Tso writes: > 2) You need to set the flag *before* you calculate the block group > checksum, not afterwards. Sorry about this. I forgot to do the quilt refresh (and check that the code I submit is the same that the code I run). > 1) You didn't include a Developer's Certification of Origin (i.e., a > "Signed-off-by" header). Since this is a one line patch, and it seems > pretty clear your intention is to submit this to Linus, This was really an RFC, as you also pointed out. Regarding this patch, the discussion raised the question of whether EXT4_BG_INODE_UNINIT or EXT4_BG_ITABLE_UNINIT would be more coherent than EXT4_BG_INODE_ZEROED wrt. EXT4_BG_INODE_UNINIT and EXT4_BG_BLOCK_UNINIT. This was also used as an example for the discussion about doing the initialization outside of an init thread (which turned up not to be a good idea). This is also the first use of EXT4_BG_INODE_ZEROED in the kernel, so an occasion to revisit the name. I did not look carefully in the progs (EXT2_BG_INODE_ZEROED) to see if it is desirable and easy to change it. cscope indicates that it may be easy (4 instances). > So the corrected patch should look like this.... Thank you, that's settled then, -- solofo -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
