On Mon, Nov 24, 2008 at 01:13:52PM -0800, Andrew Morton wrote: > > I'm scratching my head trying to work out why we never encountered and > fixed this before. > > Is it possible that you have a very large number of filesystems > mounted, and/or that they have large journals? In Okajima-san's original test case, he was running on a 128 meg system, and created an ext3 filesystem which with a 512 meg journal. This could very well be a "Doctor, doctor, it hurts when I do that" sort of thing, although I can see this being a believable situation for small NAS boxes. Even with his patches, though, this sort of configuration can run into memory pressure problems, since if a transaction grows too big, too many memory pages will get pinned, and we currently won't close a transaction early if we seem to be pinning too much memory and we are running into memory pressure issues (although this would be a good idea). So his patches will postpone the OOM killer from running, but if the journal is sufficiently large (thus allowing sufficiently large transactions), and the amount of memory sufficiently small, we still could run into OOM situations. > Would it not be more logical if the ->client_releasepage function > pointer were a member of the blockdev address_space_operations, rather > than some random field in the blockdev inode? That arrangement might > well be reused in the future, when some other address_space needs to > talk to a different address_space to make a page reclaimable. I'm not sure how your suggestion would be implemented practically speaking. Right now as I undersand things the blockdev's a_ops field is an attribute of the block device and is normally a pointer to default_blkdev_aops. In Okajima-san's patch, we define the blkdev's releasepages to be a function which looks like which client_releasepage to call in the blockdev inode. If we put that field in the blockdev a_ops structure, then when when we mount the filesystem, we would have to make a copy of the blockdev's a_ops structure so we can set the client_releasepage pointer. That seems to be rather inefficient and kludgy, so I don't imagine that's what you meant. What am I missing? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
