On Thu, Nov 20, 2008 at 01:35:11PM -0500, Peter Staubach wrote: >> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >> index 772e05b..039a5a6 100644 >> --- a/fs/ext4/mballoc.c >> +++ b/fs/ext4/mballoc.c >> @@ -460,10 +460,12 @@ static void mb_free_blocks_double(struct inode *inode, struct ext4_buddy *e4b, >> blocknr += >> le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); >> + ext4_unlock_group(sb, e4b->bd_group); >> ext4_error(sb, __func__, "double-free of inode" >> " %lu's block %llu(bit %u in group %u)\n", >> inode ? inode->i_ino : 0, blocknr, >> first + i, e4b->bd_group); >> + ext4_unlock_group(sb, e4b->bd_group); >> > > This should be ext4_lock_group(sb, e4b->bd_group); shouldn't it? Yes, I need to update at two place diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 039a5a6..728221e 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -465,7 +465,7 @@ static void mb_free_blocks_double(struct inode *inode, struct ext4_buddy *e4b, " %lu's block %llu(bit %u in group %u)\n", inode ? inode->i_ino : 0, blocknr, first + i, e4b->bd_group); - ext4_unlock_group(sb, e4b->bd_group); + ext4_lock_group(sb, e4b->bd_group); } mb_clear_bit(first + i, e4b->bd_info->bb_bitmap); } @@ -4621,7 +4621,7 @@ ext4_mb_free_metadata(handle_t *handle, struct ext4_buddy *e4b, ext4_error(sb, __func__, "Double free of blocks %d (%d %d)\n", block, entry->start_blk, entry->count); - ext4_unlock_group(sb, e4b->bd_group); + ext4_lock_group(sb, e4b->bd_group); return 0; } } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
